From 8e731560ffa5370e7376689441600de0e084917e Mon Sep 17 00:00:00 2001 From: Ryan Lortie Date: Wed, 20 Aug 2014 15:43:09 -0400 Subject: [PATCH] GtkMenuTrackerItem: fix submenu visibility flag We were only properly setting the "is-visible" flag to TRUE for menu items with associated actions and not (for example) on submenus. This was fine because the code for building GtkMenus from models (correctly) assumed that submenus should always be visible and never checked the property. This is not true for the Mac OS code, which actually checked the property and found it to be false for submenus. Initialise the property to TRUE so that we get the correct value reported for items that don't have actions. https://bugzilla.gnome.org/show_bug.cgi?id=735122 --- gtk/gtkmenutrackeritem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gtk/gtkmenutrackeritem.c b/gtk/gtkmenutrackeritem.c index 56b914f428..a815d330c4 100644 --- a/gtk/gtkmenutrackeritem.c +++ b/gtk/gtkmenutrackeritem.c @@ -556,7 +556,10 @@ _gtk_menu_tracker_item_new (GtkActionObservable *observable, g_variant_unref (state); } else - self->sensitive = TRUE; + { + gtk_menu_tracker_item_update_visibility (self); + self->sensitive = TRUE; + } return self; } -- 2.30.2